RDKEMW-21075 : BtrCore_BTGetPairedDeviceInfo crash - #81
Open
PreethiALPI wants to merge 1 commit into
Open
Conversation
Reason for change: Crash Test Procedure: DEEPSLEEP/Reboot Risks: Medium Priority: P1 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens BtrCore_BTGetPairedDeviceInfo() against crash conditions seen across deepsleep/reboot by adding defensive validation and safer D-Bus message handling when querying BlueZ managed objects and device properties.
Changes:
- Added argument/handle validation (including
pDBusConn) before issuing D-Bus calls. - Fixed boolean property extraction to use
dbus_bool_tand added bounds/empty-path guards when collecting paired device paths. - Improved D-Bus message lifecycle safety (NULL checks, append-args failure handling, and additional unrefs/NULLing).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4701
to
+4705
| if (!apstBtIfceHdl || !apBtAdapter || !pPairedDeviceInfo || | ||
| !pstlhBtIfce || !pstlhBtIfce->pDBusConn) { | ||
| BTRCORELOG_ERROR ("NULL check failed.\n"); | ||
| return -1; | ||
| } |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Crash
Test Procedure: DEEPSLEEP/Reboot
Risks: Medium
Priority: P1